fix: Get same sector size disks for multi device LVM tests #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some storage pools cannot be created on disks with different sector sizes so we want to be able to find unused disks with the same sector sizes for our tests. Related: RHEL-25994
LVM VGs cannot be created on top of disks with different sector sizes so for tests that need multiple disks we need to make sure we get unused disks with the same sector size. Resolves: RHEL-25994
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
=======================================
Coverage 16.54% 16.54%
=======================================
Files 2 2
Lines 284 284
Branches 79 79
=======================================
Hits 47 47
Misses 237 237
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
spetrosi
reviewed
May 30, 2024
The find_unused_disks module is not public, we use it only in tests. |
richm
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LVM doesn't allow creating VGs on top of disks with different sector sizes and when running our tests on machine with disks with both 512 and 4096 sectors LVM tests that use multiple disks can fail. This change adds a new option to the find_unused_disks module to request disks with the same sector sizes and uses this new option in the LVM tests that use multiple disks.
Issue Tracker Tickets (Jira or BZ if any): RHEL-25994