Pass -F to mke2fs for whole disks in RHEL #154
Conversation
|
This pull request introduces 1 alert when merging 951e1c8 into ab163df - view on LGTM.com new alerts:
|
pcahyna
force-pushed
the
el7-ext4-whole-disk-rebased
branch
from
951e1c8 to
b4029ed
Compare
|
it is WIP because I need to document the new option, but the code should be ready. |
vars/CentOS_7.yml
Outdated
| @@ -6,3 +6,7 @@ blivet_package_list: | |||
| - libblockdev-lvm | |||
| - libblockdev-mdraid | |||
| - libblockdev-swap | |||
| __storage_blivet_mkfs_option_map: | |||
There was a problem hiding this comment.
Only BlivetDiskVolume uses this map. Shouldn't the map also have something to indicate which volume type the arguments apply to?
There was a problem hiding this comment.
You are right, I'll change the name, of the module parameter as well.
There was a problem hiding this comment.
Addressed in last commit.
pcahyna
changed the title
With merging of linux-system-roles#97 the error message when resizing a volume to a too large size got changed. Account for that in the test.
More descriptive name both for Ansible and Python variables, and add documentation
pcahyna
force-pushed
the
el7-ext4-whole-disk-rebased
branch
from
ae61f10 to
c22e0c8
Compare
|
Rebased on top of #158 to make tests pass. |
There was a problem hiding this comment.
I don't love it, largely because it suggests we would need to add a new map and parameter for each volume/pool type that needs such tweaks. It does have the advantage of being mostly contained in user-friendly yaml. I think if we need to improve it somehow later we can do that, but this is fine as a solution to the immediate problem of rhel7 mke2fs on whole disks.
|
It's also worth noting that there are no tests. |
|
I don't find it pretty either. For me the main advantage over your previous method is that it is using exactly the same mechanism for determining the distribution/version specific override as for any other distribution/version specific value. If this logic is hidden inside the module, it looks better, but there is some chance that in some corner case the logic inside the module will detect another distribution/version than the logic of the role. |
|
Yeah, consistency is good. |
rebased and changed version of #128
Fixes #122