fix: add missing pmie webhook action configuration functionality #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves Red Hat issue RHEL-13760
natoscott
force-pushed
the
webhook-event-notification
branch
from
7bc8406 to
a5e8a35
Compare
|
[citest] |
1 similar comment
|
[citest] |
richm
reviewed
Nov 29, 2023
tests/check_notification.yml
Outdated
| --- | ||
| # yamllint disable rule:line-length | ||
| - name: Check if webhook notification is set | ||
| command: grep -e 'webhook_endpoint .* {{ __test_webhook }}' /var/lib/pcp/config/pmie/config.default |
There was a problem hiding this comment.
This doesn't match. Are you trying to match something like
& shell 10 min "pmie_webhook 'https://example.com:4242/endpoint|Restart unresponsive PMDAs" "|%h|pmda%i[%v]@%h" "'";
or something like
// 0 global webhook_endpoint = "https://example.com:4242/endpoint"
if the latter, then you'll have to use
command: grep 'webhook_endpoint .* "{{ __test_webhook }}"' /var/lib/pcp/config/pmie/config.default
to match the double quotes. If the double quotes are optional, then maybe something like
command: grep -E 'webhook_endpoint .* "?{{ __test_webhook }}"?' /var/lib/pcp/config/pmie/config.default
(note that -E turns on extended regex, not -e)
richm
reviewed
Dec 4, 2023
Fix grep search
|
[citest] |
|
@natoscott another issue - grafana is core dumping e.g. rhel9.4 tests_bz1855544.yml - the error is |
|
Superceded by #181 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Red Hat issue RHEL-13760