feat: several role improvements #8
Conversation
richm
force-pushed
the
fix-test-cleanup
branch
2 times, most recently
from
c5bc0c8 to
e00a462
Compare
richm
changed the title
richm
force-pushed
the
fix-test-cleanup
branch
from
e00a462 to
90e3949
Compare
|
@radosroka @Koncpa I realize this is a pretty big change - but with these changes, tests pass on every platform, both upstream and in our various downstream test suites |
|
oh - and another change - AFAICT the tests do not need compiled binary executables - they just need executable files - the gcc and glibc packages take a few minutes to install over a slow connection, so better to just skip them - all we really care about is that fapolicyd allows the specified executable to be run, and disallows executables with a different name or checksum |
|
[citest] |
2 similar comments
|
[citest] |
|
[citest] |
When adding files to the trustdb, wait until the server recognizes that the trustdb is updated before returning. Do not use compiled C programs for testing trust, just use executable shell scripts. Set vars such as __fapolicyd_trust_supported et. al. based on os family and version rather than using distribution version. One reason is that CentOS Stream was excluded from many features but it should be included. Clean up after tests Other minor improvements Signed-off-by: Rich Megginson <[email protected]>
richm
force-pushed
the
fix-test-cleanup
branch
from
55cecd5 to
40b3c9f
Compare
|
@Koncpa @radosroka @xjezda00 It seems that |
|
[citest] |
When adding files to the trustdb, wait until the server recognizes
that the trustdb is updated before returning.
Do not use compiled C programs for testing trust, just use
executable shell scripts.
Clean up after tests
Refactor the check of various EL versions for fapolicyd features - did not work correctly on CentOS and Fedora
make the default value for
fapolicyd_setup_enable_serviceto betrue- not sure why anyone would run the role but not want fapolicyd running - goes against every other role that manages a serviceSigned-off-by: Rich Megginson [email protected]