fix: Fix the role for UEFI systems #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[citest] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
=========================================
+ Coverage 0 78.43% +78.43%
=========================================
Files 0 2 +2
Lines 0 255 +255
=========================================
+ Hits 0 200 +200
- Misses 0 55 +55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
richm
reviewed
Feb 26, 2024
richm
reviewed
Feb 26, 2024
|
I provisioned a PowerPC machine in Beaker, and it uses grub, my tests passed on it. |
|
[citest] |
2 similar comments
|
[citest] |
|
[citest] |
- Regenerate grub config properly - Fix __bootloader_uefi_ directories for other than RHEL distributions - Add a note about supported architectuers in README - Fix licence - Use a general grub conf path if UEFI path is a stub
|
[citest] |
spetrosi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: Fix the role for UEFI systems
Reason: On UEFI systems, grub config might not have a full config, but a stub that redirects to a common config in
/boot/grub2/grub.cfg.Result: The role works properly on both BIOS on UEFI systems