fix: Modify grub timeout in grub config directly #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[citest] |
richm
reviewed
Feb 8, 2024
| regexp: '^GRUB_TIMEOUT=.*' | ||
| replace: 'GRUB_TIMEOUT={{ bootloader_timeout }}' | ||
| mode: "{{ __bootloader_grub_stat.stat.exists | | ||
| ternary(__bootloader_grub_stat.stat.mode, '0644') }}" |
There was a problem hiding this comment.
Does one apply to the current kernel, and the other applies to new kernels?
There was a problem hiding this comment.
This is general, not applied to any kernel but to the system generally. This timeout happens before you use any kernel, actually.
richm
approved these changes
Feb 8, 2024
|
[citest] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
=========================================
+ Coverage 0 78.43% +78.43%
=========================================
Files 0 2 +2
Lines 0 255 +255
=========================================
+ Hits 0 200 +200
- Misses 0 55 +55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: Modify grub timeout in grub config directly
Reason: On RHEL 7, rebuilding grub config with grubby2-mkconfig has a bug that returns previously removed kernels
Result: This workaround doesn't require rebuilding grub config and hence avoids the bug