feat: Import code for role #3
Conversation
Signed-off-by: Radovan Sroka <[email protected]>
Signed-off-by: Radovan Sroka <[email protected]>
|
[citest] |
|
[citest] |
|
[citest] |
README.md
Outdated
| ``` | ||
| ### aide_generate_config | ||
|
|
||
| Generates the file `/etc/aide.conf` using `templates/aide.conf.j2`; the template needs to be adjusted to fit your requirements; if you do not use this varable the default configuration file shipped with the `aide` package will be used. |
There was a problem hiding this comment.
the template needs to be adjusted to fit your requirements;
What does this mean? Note that, in general, users will not be able to modify the template file. Was this in the original role? If so, then I guess that use case was different i.e. as a consultant, I need to install this role in a writable directory on the customers machine and modify and run the role as I require for my particular use case. This is definitely not the linux system roles use case, where the only thing the user may do is modify the inventory and the playbook, and provide files/templates - nothing else.
If we really want users to be able to provide custom configuration, then we should do either/both of these things:
- Users can provide a list of configuration parameters that are written in the template
- Users can provide their own
aide.conffile or template
There was a problem hiding this comment.
the template needs to be adjusted to fit your requirements;
What does this mean? Note that, in general, users will not be able to modify the template file. Was this in the original role? If so, then I guess that use case was different i.e. as a consultant, I need to install this role in a writable directory on the customers machine and modify and run the role as I require for my particular use case. This is definitely not the linux system roles use case, where the only thing the user may do is modify the inventory and the playbook, and provide files/templates - nothing else.
If we really want users to be able to provide custom configuration, then we should do either/both of these things:
1. Users can provide a list of configuration parameters that are written in the template 2. Users can provide their own `aide.conf` file or template
Yeah, as you pointed out, this was designed originally for different use case. Let me evaluate options.
There was a problem hiding this comment.
In case user provides aide.conf should we prepend ansible_managed comment?
There was a problem hiding this comment.
In case user provides aide.conf should we prepend ansible_managed comment?
No - if the user provides the file, it is the responsibility of the user to mark the file as Ansible managed - this is the way all other system roles work
|
@richm do you know why the tests are skipped after [citest]? |
meta/main.yml
Outdated
| - fedora | ||
| - all | ||
|
|
||
| galaxy_tags: [] |
There was a problem hiding this comment.
allis not a valid specifier underEL- you must specify the major versions explicitly - so ifaideis supported on EL 9 and 10, you must use
- name: EL
versions:
- "9"
- "10"- We have to use galaxy_tags now to specify platform support - support for
platforms:is being deprecated - see fix: add support for EL10 .github#63 for additional information - this is why the template has explicitgalaxy_tags- so if theaiderole supports EL 9, 10, and Fedora, you need to havegalaxy_tagslike this:
galaxy_tags:
- el9
- el10
- fedora
Yes - the platforms and galaxy_tags in meta/main.yml need to be fixed - see https://github.com/linux-system-roles/aide/pull/3/files#r1832783551 |
Signed-off-by: Radovan Sroka <[email protected]>
|
I don't know what ansible-lint is complaining about - just ignore it for now |
|
[citest] |
|
Looks like Testing Farm is having some issues right now |
|
[citest] |
Signed-off-by: Radovan Sroka <[email protected]>
|
[citest] |
Signed-off-by: Radovan Sroka <[email protected]>
Signed-off-by: Radovan Sroka <[email protected]>
|
[citest] |
2 similar comments
|
[citest] |
|
[citest] |
due to broken environment processing in a testing farm Signed-off-by: Radovan Sroka <[email protected]>
|
[citest] |
2 similar comments
|
[citest] |
|
[citest] |
Signed-off-by: Radovan Sroka <[email protected]>
|
[citest] |
Signed-off-by: Radovan Sroka <[email protected]>
tasks/main.yml
Outdated
| when: | ||
| - aide_db_template is defined | ||
| - aide_db_template is not none | ||
| - aide_db_template is string |
There was a problem hiding this comment.
What else aide_db_template can be? I think this check is not required
There was a problem hiding this comment.
It can be user defined string or null by default.
This reverts commit 21c7645.
Signed-off-by: Radovan Sroka <[email protected]>
|
[citest] |
Signed-off-by: Radovan Sroka <[email protected]>
Enhancement: Add initial code for the aide system role