Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add default_ipv4 to required_facts to gather ansible_hostname #84

Merged
merged 1 commit into from
Feb 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/tests_dyndns.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

- name: Ensure that the role configures dynamic dns
hosts: all,!ad
gather_facts: false
vars:
# if we don't have a real AD server, just verify the config
# file is written properly
Expand Down
1 change: 1 addition & 0 deletions vars/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ __ad_integration_required_facts:
- distribution_major_version
- distribution_version
- os_family
- default_ipv4
# the subsets of ansible_facts that need to be gathered in case any of the
# facts in required_facts is missing; see the documentation of
# the 'gather_subset' parameter of the 'setup' module
Expand Down
Loading