refactor: use the ini_file module to test sssd.conf #67
Conversation
richm
force-pushed
the
refactor-ini-handling
branch
from
46afc97 to
2180036
Compare
|
[citest] |
I'm not QE so I will defer to @jakub-vavra-cz but I thought it would be better skip this test when AD is not available, to not give the false impression that dynamic DNS testing was successful in the case of a single host where dynamic DNS functionality is impossible. Unrelated, one minor typo in the filename Code changes LGTM. |
Understood - but I really wanted to have a way to test the ini file handling stuff without having to set up a real AD. And I did uncover an issue with the tests_dyndns.yml If you do have a linux and an AD host in your inventory, the test will check that DNS is configured properly.
Thanks - fixed
|
richm
force-pushed
the
refactor-ini-handling
branch
from
2180036 to
543ab65
Compare
The `ini` lookup is problematic with ansible 2.9 due to the
arguments being completely different, and because ansible attempts
to evaluate `{{ lookup('ini', ...) }}` even if guarded by a `when`,
any use of the new style 2.x `ini` arguments will fail.
Instead, just use the `ini_file` module itself, and rely on the fact
that it will report `changed: true` if the values are different.
Use `community.general.ini_file` instead of `ini_file` everywhere
for consistency.
Refactor the `tests_dyndns.yml` test so that it works in CI with
a single host - in that case, just check that the sssd.conf was
written correctly.
Rename tests_sssd_custom_setttings.yml to tests_sssd_custom_settings.yml
Use the new `ad_integration_sssd_custom_settings` in tests instead of
writing to sssd.conf directly with `ini_file`
The `tests_dyndns.yml` test wasn't working properly - in order for
any parameters to be set, you must specify `ad_dyndns_update: true`
Use non-FQCN `win_command` in a couple of places that Ansible 2.9 was
giving an error about.
Signed-off-by: Rich Megginson <[email protected]>
richm
force-pushed
the
refactor-ini-handling
branch
from
543ab65 to
a71b826
Compare
|
[citest] |
|
Ack from my side. Thank you for taking care of it. |
The
inilookup is problematic with ansible 2.9 due to thearguments being completely different, and because ansible attempts
to evaluate
{{ lookup('ini', ...) }}even if guarded by awhen,any use of the new style 2.x
iniarguments will fail.Instead, just use the
ini_filemodule itself, and rely on the factthat it will report
changed: trueif the values are different.Refactor the
tests_dyndns.ymltest so that it works in CI witha single host - in that case, just check that the sssd.conf was
written correctly.
The
tests_dyndns.ymltest wasn't working properly - in order forany parameters to be set, you must specify
ad_dyndns_update: trueSigned-off-by: Rich Megginson [email protected]