Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename nvme_cmd_get_log_telemetry_host_lsp to nvme_log_telemetry_host_lsp #477

Open
igaw opened this issue Sep 22, 2022 · 1 comment
Open

Rename nvme_cmd_get_log_telemetry_host_lsp to nvme_log_telemetry_host_lsp #477

igaw opened this issue Sep 22, 2022 · 1 comment
Labels
enhancement New feature or request
Milestone
2.0

Comments

@igaw
Copy link
Collaborator

igaw commented Sep 22, 2022

Agreed. I will drop the get.
FWIW, I was trying to stay consistent with another "get log" LSP enum (i.e. nvme_cmd_get_log_telemetry_host_lsp)

Originally posted by @martin-belanger in #476 (comment)
@igaw igaw added this to the 2.0 milestone Sep 22, 2022
@igaw igaw added the enhancement New feature or request label Sep 26, 2022
@ikegami-t ikegami-t mentioned this issue Jun 17, 2023
Closed
@ikegami-t
Copy link
Contributor

As mentioned by #663 (comment) should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@igaw @ikegami-t