types: Rename nvme_cmd_get_log_telemetry_host_lsp to nvme_log_telemet… #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry_host_lsp Signed-off-by: Tokunori Ikegami <[email protected]>
Signed-off-by: Tokunori Ikegami <[email protected]>
|
Changes for the issue #477. |
|
Thanks for these changes. Note, the #477 issue is one of the 2.0 milestones issues. Most the 2.0 milestone issue are breaking the existing API. Given that we are going to generate the API from the upcoming official NVME JSON file, the #477 issue doesn't really make sense at all. I think we should just close it. |
|
Thanks for your review comments. Okay will close the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ry_host_lsp