Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree_match: handle bpf-next/net #44

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

matttbe
Copy link
Member

@matttbe matttbe commented Nov 4, 2024

For a few months now [1], BPF patches that are "Networking related" should have the "bpf-next/net" prefix.

With the previous order, the PW poller was considering this prefix as "for net", leading to these results on Patchwork [2]:

Context Check Description
netdev/tree_selection success Clearly marked for net
netdev/apply fail Patch does not apply to net-0

By changing the order of the list, such patches with "[bpf-next/net]" will be marked for "bpf-next", and they will not be applied locally like it was the case before with "bpf-next" patches.

Link: https://lore.kernel.org/netdev/CAADnVQJgwGh+Jf=DUFuX28R2bpWVezigQYObNoKJT8UbqekOHA@mail.gmail.com/ [1]
Link: https://patchwork.kernel.org/project/netdevbpf/patch/c02fda3177b34f9e74a044833fda9761627f4d07.1730338692.git.tanggeliang@kylinos.cn/ [2]

For a few months now [1], BPF patches that are "Networking related"
should have the "bpf-next/net" prefix.

With the previous order, the PW poller was considering this prefix as
"for net", leading to these results on Patchwork [2]:

   Context              |  Check  |  Description
  ----------------------|---------|------------------------------
  netdev/tree_selection | success | Clearly marked for net
  netdev/apply          | fail    | Patch does not apply to net-0

By changing the order of the list, such patches with "[bpf-next/net]"
will be marked for "bpf-next", and they will not be applied locally like
it was the case before with "bpf-next" patches.

Link: https://lore.kernel.org/netdev/CAADnVQJgwGh+Jf=DUFuX28R2bpWVezigQYObNoKJT8UbqekOHA@mail.gmail.com/ [1]
Link: https://patchwork.kernel.org/project/netdevbpf/patch/c02fda3177b34f9e74a044833fda9761627f4d07.1730338692.git.tanggeliang@kylinos.cn/ [2]
Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
@matttbe matttbe requested a review from kuba-moo November 4, 2024 10:35
@kuba-moo kuba-moo merged commit b0fb656 into linux-netdev:main Nov 5, 2024
1 check passed
@kuba-moo
Copy link
Contributor

kuba-moo commented Nov 5, 2024

Restarting the build tester with patches in the queue scares me so I will probably deploy on the weekend ;)
Thanks!

@matttbe matttbe deleted the bpf-next-net branch November 5, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants