laurent: driver for KernelChip Laurent family of relays #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for the KernelChip Laurent-2 / Laurent-5 / Laurent-112 / Laurent-128 network-controlled relay arrays. Signed-off-by: Dmitry Baryshkov <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
superna9999
reviewed
Mar 31, 2024
| properties: | ||
| server: | ||
| type: string | ||
| relay: |
There was a problem hiding this comment.
Is this the relay port number ? Perhaps use something like "port" instead
There was a problem hiding this comment.
I don't want for it to be confused with the TCP port on which to talk to the server.
konradybcio
reviewed
Apr 8, 2024
| static int laurent_power(struct device *dev, bool on) | ||
| { | ||
| struct laurent *laurent = dev->cdb; | ||
| char buf[BUFSIZ]; |
There was a problem hiding this comment.
I suppose it's safe to assume nobody has a 470+ bytes long password
There was a problem hiding this comment.
Don't give me wrong ideas!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the KernelChip Laurent-2 / Laurent-5 / Laurent-112 / Laurent-128 network-controlled relay arrays.