Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ftdi gpio yaml parsing #44

Merged
merged 2 commits into from
Nov 4, 2023
Merged

Ftdi gpio yaml parsing #44

merged 2 commits into from
Nov 4, 2023

Conversation

superna9999
Copy link
Member

@superna9999 superna9999 commented Oct 30, 2023 •
edited
Loading

Switch from:

    ftdi_gpio: "s:0xVEND:0xPROD:SERIAL;D;POWER,0,ACTIVE_LOW;FASTBOOT_KEY,1,ACTIVE_HIGH;POWER_KEY,2,ACTIVE_HIGH;USB_DISCONNECT,3,ACTIVE_LOW"

to

    ftdi_gpio:
     vendor: "0xVEND"
      product: "0xPROD"
      serial: SERIAL
      power:
        interface: D
        line: 7
        active_low: true
      fastboot_key:
        interface: D
        line: 8
        active_low: true
      power_key:
        interface: D
        line: 3
        active_low: true
      usb_disconnect:
        interface: D
        line: 2

but still accept the previous format with a warning

Follows schema specified in #46 https://github.com/linux-msm/cdba/pull/46/files#diff-de05320774ffa1b4e469ebacba38ff3001bf8c561d85c6f5d8410c5adeea3455R92

Closes: #42

@superna9999 superna9999 force-pushed the ftdi-gpio-yaml-parsing branch 2 times, most recently from 3e85f9c to cf9f3d3 Compare October 31, 2023 12:32
@lumag lumag mentioned this pull request Nov 1, 2023
Closed
4 tasks
@superna9999
ftdi_gpio: align structs with local_gpio
6d95341 
Signed-off-by: Neil Armstrong <[email protected]>
@superna9999
ftdi_gpio: accept new yaml config
a2ae597 
Now local_gpio has landed, also accept a more verbose
and cleaner yaml config syntax for ftdi_gpio.

For now keep support for the current configuration string.

Closes: linux-msm#42

Signed-off-by: Neil Armstrong <[email protected]>
@superna9999 superna9999 force-pushed the ftdi-gpio-yaml-parsing branch from cf9f3d3 to a2ae597 Compare November 2, 2023 17:19
@superna9999 superna9999 marked this pull request as ready for review November 2, 2023 17:20
@superna9999 superna9999 requested a review from lumag November 2, 2023 17:20
@lumag lumag enabled auto-merge November 4, 2023 10:14
@lumag lumag merged commit 01ebafc into linux-msm:master Nov 4, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumag lumag lumag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add YAML config for ftdi_gpio
2 participants
@superna9999 @lumag