Add Alpine Linux CI and stop enabling werror for everyone #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebccff
force-pushed
the
werror-and-alpine
branch
4 times, most recently
from
5d6aed6 to
7993619
Compare
|
@calebccff could you please fix the error reported on Debian / buster? |
|
i realise i did almost exactly what you have in if you want to just merge that I'll adjust this pr to just add alpine CI |
calebccff
force-pushed
the
werror-and-alpine
branch
2 times, most recently
from
57d45d9 to
362df00
Compare
superna9999
approved these changes
Oct 30, 2023
superna9999
reviewed
Oct 30, 2023
superna9999
requested changes
Oct 30, 2023
lumag
requested changes
Nov 2, 2023
There was a problem hiding this comment.
@calebccff could you please follow @superna9999 's suggestions?
Silence Clang warning by removing unused '0' from struct initialisation. Signed-off-by: Dmitry Baryshkov <[email protected]>
calebccff
force-pushed
the
werror-and-alpine
branch
from
362df00 to
82e937c
Compare
Enabling -Werror by default sucks for everyone who isn't maintaining CDBA. By all means we should enable it in CI, but not for users and not for folks packaging it in distros. Remove it from the flags in meson.build, and use mesons built in option to enable it only in CI. See: https://embeddedartistry.com/blog/2017/05/22/werror-is-not-your-friend/ Signed-off-by: Caleb Connolly <[email protected]>
I plan to package CDBA in alpine, as it uses musl libc it is a lot easier for things to break there. Add alpine latest edge and stable build tests to catch these. Signed-off-by: Caleb Connolly <[email protected]>
calebccff
force-pushed
the
werror-and-alpine
branch
from
82e937c to
67f2d38
Compare
lumag
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling -Werror by default sucks for everyone who isn't maintaining
CDBA. By all means we should enable it in CI, but not for users and
not for folks packaging it in distros.
Remove it from the flags in meson.build, and use mesons built in option
to enable it only in CI.
See:
https://embeddedartistry.com/blog/2017/05/22/werror-is-not-your-friend/
I plan to package CDBA in Alpine soon, having build tests for it in CI will help ensure that we avoid easy regressions like missing headers (yay musl..)