only enable -Werror in CI

Enabling -Werror by default sucks for everyone who isn't maintaining
CDBA. By all means we should enable it in CI, but not for users and
not for folks packaging it in distros.

Remove it from the flags in meson.build, and use mesons built in option
to enable it only in CI.

See:
https://embeddedartistry.com/blog/2017/05/22/werror-is-not-your-friend/

Signed-off-by: Caleb Connolly <[email protected]>

.github/workflows/ci.yml

@@ -207,7 +207,7 @@ jobs:
       if: ${{ matrix.variant == 'i386' }}
       run: |
         mkdir build
-        CFLAGS="-m32" LDFLAGS="-m32" meson setup . build
+        CFLAGS="-m32" LDFLAGS="-m32" meson setup -Dwerror=true . build
 
     - name: Meson init with cross compile
       if: ${{ matrix.variant == 'cross-compile' }}
@@ -227,13 +227,13 @@ jobs:
         echo "pkg_config_libdir = '${PKG_CONFIG_PATH}'" >> cross.txt
         cat cross.txt
         mkdir build
-        meson setup --cross-file cross.txt . build
+        meson setup -Dwerror=true --cross-file cross.txt . build
 
     - name: Meson init
       if: ${{ matrix.variant == '' }}
       run: |
         mkdir build
-        meson setup . build
+        meson setup -Dwerror=true . build
 
     - name: Compile
       run: ninja -C build

meson.build

@@ -26,8 +26,7 @@ compiler_cflags = ['-Wno-unused-parameter',
 
 # TODO add clang specific options
 if compiler.get_id() == 'gcc'
-	compiler_cflags += ['-Werror',	# Only set it on GCC
-			    '-Wformat-signedness',
+	compiler_cflags += ['-Wformat-signedness',
 			    '-Wduplicated-cond',
 			    '-Wduplicated-branches',
 			    '-Wvla-larger-than=1',