canlogserver: Fix termination after signal #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this commit should be "canlogserver: fix termination after signal" Because before that there was a proper exit of the application. |
With f45de1b, we've removed unsafe function exit(3) from the signal handler. But that made canlogserver's accept(3)ing process not exit; It unconditionally keeps running with EINTR. Check the variable "running" when signaled and exit with an appropriate error code. Fixes: f45de1b ("canlogserver: Follow Bash exit status when signaled") Signed-off-by: Yasushi SHOJI <[email protected]>
yashi
force-pushed
the
canlogserver-exit-when-signaled
branch
from
eafcf29
to
0d276a1
Compare
yashi
changed the title
|
@hartkopp ping |
marckleinebudde
requested changes
May 15, 2023
Comment on lines
308
to
+309
| } | ||
| else if ((errno == EINTR) && !running) { |
There was a problem hiding this comment.
Suggested change
| } | |
| else if ((errno == EINTR) && !running) { | |
| } else if ((errno == EINTR) && !running) { |
Comment on lines
+311
to
+316
| if (signal_num) { | ||
| return 128 + signal_num; | ||
| } | ||
| else { | ||
| return 1; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (signal_num) { | |
| return 128 + signal_num; | |
| } | |
| else { | |
| return 1; | |
| } | |
| if (signal_num) | |
| return 128 + signal_num; | |
| else | |
| return 1; |
marckleinebudde
requested changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With f45de1b, we've removed unsafe function exit(3) from the signal handler. But that made canlogserver's accept(3)ing process not exit; It unconditionally keeps running with EINTR.
Check the variable "running" when signaled and exit with an appropriate error code.