Log runlevel changes to console (during boot) #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Audit may initiate runlevel changes in several scenarios, such as when available disk space for audit logs becomes critically low. In these situations, audit can halt the system during boot, but without clear evidence indicating that audit was responsible for the shutdown. With the patch applied, audit will write to /dev/console when doing runlevel changes.
|
The printf function attribute should be added to the function prototype. Look at audit_msg for an example. Also, normally we send messages after we perform the action in case the change fails. (There were cases in the past where something with init changed and it was unable to change to single user mode.) For halt, you have to send it before. |
If runlevel is not HALT, we will wait until initd returns an exit code. After that we can display to console if it succeeded.
Cropi
changed the title
During boot and auditd initialization, auditd is not fully initialized and operational. This means that when calling init_event(), we can't notify the parent process that initialization is complete. However, if space_left_action is set to SINGLE, we must avoid switching to that runlevel (during boot). Before entering the SINGLE runlevel, it requires auditd to finish initialization. But auditd will not start properly or signal the init system that it has started, as it is blocked by the attempt to switch to single-user mode, resulting in a deadlock.
|
I put some comments under https://github.com/linux-audit/audit-userspace/pull/413/files#diff-561528b72c0692af52f6b4c90aae3f9ee3732c5837f448cddd68871a91cf6649R191. I was playing with options such as |
Cropi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audit may initiate runlevel changes in several scenarios, such as when available disk space for audit logs becomes critically low. In these situations, audit can halt the system during boot, but without clear evidence indicating that audit was responsible for the shutdown. With the patch applied, audit will write to
/dev/consolewhen doing runlevel changes.This comes in handy during boot, so sysadmins can track down the root cause of the shutdown much faster.