Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Linode resize to differentiate between warm and cold migrations #1728

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Update Linode resize to differentiate between warm and cold migrations #1728

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90f1bd6
Differentiate between migration types for instance resize
ezilber-akamai Jan 16, 2025
44caed1
Merge branch 'dev' into TPT-3462-fix-instance-resize
ezilber-akamai Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions linode/instance/helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,9 +754,21 @@ func changeInstanceType(
diskResize bool,
d *schema.ResourceData,
) (*linodego.Instance, error) {
instance, err := ensureInstanceOffline(ctx, client, instanceID, getDeadlineSeconds(ctx, d))
if err != nil {
return nil, err
var err error
var instance *linodego.Instance

if migrationType == linodego.ColdMigration {
// Cold migration: Ensure instance is offline
instance, err = ensureInstanceOffline(ctx, client, instanceID, getDeadlineSeconds(ctx, d))
if err != nil {
return nil, fmt.Errorf("failed to shut down instance for cold migration: %w", err)
}
} else {
// Warm migration: Get the current instance state
instance, err = client.GetInstance(ctx, instanceID)
if err != nil {
return nil, fmt.Errorf("failed to fetch instance details for warm migration: %w", err)
}
}

var primaryDisk *linodego.InstanceDisk
Expand Down
Loading