Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Resty as a dependency #576

Merged
merged 20 commits into from
Oct 25, 2024
Merged

Drop Resty as a dependency #576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
8cbafb0
Unit tests passing
ezilber-akamai Sep 24, 2024
964448e
Remove all references to Resty
ezilber-akamai Sep 24, 2024
77adeb4
Fixed some integration tests
ezilber-akamai Sep 27, 2024
33be8fb
Fixed failing integration tests
ezilber-akamai Sep 27, 2024
bbf149e
Merge main into TPT-2965-drop-resty
ezilber-akamai Sep 30, 2024
5d250dc
Fix lint
ezilber-akamai Sep 30, 2024
07f92a7
Fixed request body not being logged
ezilber-akamai Oct 1, 2024
30b5fc5
Fixed issue where request body did not get reset for retry
ezilber-akamai Oct 1, 2024
b140b95
Fix lint
ezilber-akamai Oct 1, 2024
901873c
Fixed issue with image uploads
ezilber-akamai Oct 7, 2024
1e2090b
build(deps): bump golang.org/x/text from 0.18.0 to 0.19.0 (#587)
dependabot[bot] Oct 7, 2024
34f622c
ci: Fix workflow failures in PRs due to slack notify step (#588)
ykim-akamai Oct 7, 2024
e8ef722
Merge main into TPT-2965-drop-resty
ezilber-akamai Oct 7, 2024
09a3567
Fixed intermittent error
ezilber-akamai Oct 8, 2024
10f8214
Addressed more PR comments
ezilber-akamai Oct 9, 2024
228fbaa
Addressed more PR comments
ezilber-akamai Oct 9, 2024
4d7ed7d
Addressed some more PR comments
ezilber-akamai Oct 22, 2024
6a71272
Added default values for retry times
ezilber-akamai Oct 23, 2024
236747a
Updated body type in requestParams
ezilber-akamai Oct 23, 2024
ccbde3b
Addressed more PR comments
ezilber-akamai Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:

- name: Fail if changes
run: git diff-index --exit-code HEAD

test:
runs-on: ubuntu-latest
env:
Expand Down Expand Up @@ -81,7 +81,7 @@ jobs:
notify-slack:
runs-on: ubuntu-latest
needs: [test]
if: always() && github.repository == 'linode/linodego' # Run even if integration tests fail and only on main repository
if: always() && github.ref == 'refs/heads/main' && github.event_name == 'push' # Run even if integration tests fail and only on main repository
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add the condition github.ref == 'refs/heads/main' && github.event_name == 'push' along with github.repository == 'linode/linodego' to limit slack notifications?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's already in main? Maybe we can do some main -> proj -> this-branch merges?


steps:
- name: Notify Slack
Expand Down
Loading