feat: updating apl-tools [TOOLS][MINOR] #1735
Open
+17
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CasLubbers
requested changes
Sep 30, 2024
| # https://github.com/jkroepke/helm-secrets/releases | ||
| ARG HELM_SECRETS_VERSION=3.15.0 | ||
| ARG HELM_SECRETS_VERSION=4.6.1 |
There was a problem hiding this comment.
This upgrade has breaking changes. https://github.com/jkroepke/helm-secrets/blob/main/CHANGELOG.md#400---2022-09-11
I think we can solve this by updating src/common/crypt.ts
enum CryptType {
ENCRYPT = 'helm secrets encrypt -f',
DECRYPT = 'helm secrets decrypt -f',
ROTATE = 'sops --input-type=yaml --output-type=yaml -i -r',
}
There was a problem hiding this comment.
Reverted to 3.16 which seems to be latest version. Somehow I ended up in the unreleased section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the tools in the apl-tools image. Once merged this commit will create the new 2.7.0 image version via the "APL Tools Build and Versioning" pipeline. This means the first run of the "Build and publish Docker" pipeline will fail since the new 2.7.0 image will not be ready. Rerunning it should solve the issue.