fix: scope metric variables to collector function #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps fix some concurrency problems by registering the metrics once outside the collector and introducing a mutex lock when values get updated
this cuts down on the long parameter list in the collector function
wbollock
changed the title
Turns out the entire contention/value leakage issue was just due to these globals in the icmp collector function
wbollock
changed the title
wbh1
reviewed
Dec 14, 2023
Co-authored-by: Will Hegedus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps fix some concurrency problems by scoping and instantiating metric variables to each probe.
It also tightens up the ping_success logic to closely match
man pingand provide Info logs on ping timeout or other failuresLastly there is a refactor to reduce the long parameter list in the collector function