feat: add page.setContent
#17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowlighter
commented
Oct 9, 2023
| write: (html: string) => void; | ||
| close: () => void; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
I wasn't too sure how to enable the dom typing just for this block code 😅
I can change it if you know how to achieve this
There was a problem hiding this comment.
As far as I am aware, there isn't really a way to achieve this functionality unfortunately. Triple slash directives only seem to be valid at the top level, which is really unfortunate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
page.setContent()methodMostly ported from
https://github.com/puppeteer/puppeteer/blob/067a5b290083adcb297231ed360cec27ce2e4155/packages/puppeteer-core/src/common/util.ts#L554-L565