-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with Redmine 5 (#25) #28
base: master
Are you sure you want to change the base?
Conversation
Same here 😄 that's why I did not create the PR, because I am not even sure that plugin works on Redmine 5.x (I don't use it at the moment), Redmine just refused to work properly until I applied those changes to plugin |
Also, I realized yesterday that the "listen" gem needs to be added as a dependency, but I do not know how this is supposed to be done. |
Hi @felmab,
Fix: In the same redmine_git_mirror/init.rb file you also need to change require 'redmine_git_mirror/patches/repositories_helper_patch' line to this: Source: #25 |
As I said, I am no Ruby developer. I tried to provide something the best I could. Since you seem to be more knowledgeable than I am, you might want to provide an amended version of this PR ^^ |
I have forked your repository and done further changes so that it works now completly fine with redmine 5. The changes aren't on a high programming level cause I'm not a ruby programmer but they fixed the issues with the new Rails-Version. |
Applied most of the changes suggested by @HarrySky in #25.
Beware I am not a Ruby developer!