Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AllSegmentsWalkerBase new documentation #137

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
d5ffa31
Documentation for file AllSegmentsWalkerBase
kiritozevs Aug 26, 2021
8b3574c
Documentation for file AllSegmentsWalkerBase
kiritozevs Aug 26, 2021
15e2219
new documentation for a AllSegmentsWalkerBase[T]
kiritozevs Aug 27, 2021
1aedf15
new documentation for a AllSegmentsWalkerBase[T]
kiritozevs Aug 27, 2021
7794022
New version
kiritozevs Aug 27, 2021
1e58742
New version2
kiritozevs Aug 27, 2021
612af57
New version3
kiritozevs Aug 27, 2021
d325d15
Opa Gan Gnam Style
kiritozevs Aug 28, 2021
b598dd9
Opa Gan Gnam Style2
kiritozevs Aug 28, 2021
0f9964a
Opa Gan Gnam Style3
kiritozevs Aug 28, 2021
3c54612
Opa Gan Gnam Style 2.1
kiritozevs Aug 28, 2021
eeb35b3
new elemets param text
kiritozevs Aug 29, 2021
56a0b4c
new elemets param text2
kiritozevs Aug 29, 2021
55e6fae
100 Thousand Hour Leter
kiritozevs Aug 29, 2021
f541c3f
Probel
kiritozevs Aug 29, 2021
ccbd3c7
Delete Probel
kiritozevs Aug 30, 2021
f275571
This
kiritozevs Sep 2, 2021
6ce8fe7
This2
kiritozevs Sep 2, 2021
1c0eade
Meybe_Last
kiritozevs Sep 3, 2021
90dd4ce
Return
kiritozevs Sep 3, 2021
804cd45
konstantin
kiritozevs Sep 4, 2021
bc38b9a
new_english_new_files
kiritozevs Sep 4, 2021
57c4fdc
new_english_new_files2
kiritozevs Sep 4, 2021
2af9353
New_Commit
kiritozevs Sep 4, 2021
79f9aa3
new_text
kiritozevs Sep 10, 2021
1ec0d84
extra-puper-probel
kiritozevs Sep 11, 2021
292c04c
{T}
kiritozevs Sep 11, 2021
d22f982
6_and_9_string
kiritozevs Sep 18, 2021
27baa4c
seealso_in_3_files
kiritozevs Sep 22, 2021
c40fddc
t_tsegment_class_documentation
kiritozevs Sep 22, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,17 @@
namespace Platform.Collections.Segments.Walkers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the pragma statement above because XML comments are not missing now

{
/// <summary>
/// <para>
/// Represents the all segments walker base.
/// </para>
/// <para></para>
/// <para>Represents the base class for walkers through all possible segments of a sequence.</para>
/// <para>Представляет базовый класс для проходчиков по всем возможным сегментам последовательности.</para>
/// </summary>
Konard marked this conversation as resolved.
Show resolved Hide resolved
/// <seealso cref="AllSegmentsWalkerBase{T, Segment{T}}"/>
/// <seealso cref="AllSegmentsWalkerBase{T}"/>
public abstract class AllSegmentsWalkerBase
{
/// <summary>
/// <para>
/// The default minimum string segment length.
/// </para>
/// <para></para>
/// <para>A read-only field that represents the default minimum length of the sequence segment.</para>
/// <para>Поле только для чтения, которое представляет минимальную длину сегмента последовательности по умолчанию.</para>
/// </summary>
public static readonly int DefaultMinimumStringSegmentLength = 2;
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,41 +6,34 @@
namespace Platform.Collections.Segments.Walkers
{
/// <summary>
/// <para>
/// Represents the all segments walker base.
/// </para>
/// <para></para>
/// <para>Represents the base class for walkers through all possible segments of a sequence.</para>
/// <para>Представляет базовый класс для проходчиков по всем возможным сегментам последовательности.</para>
/// </summary>
/// <seealso cref="AllSegmentsWalkerBase"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this? seealso must be used inside tags like summary, param and so on

/// <seealso cref="AllSegmentsWalkerBase{T}"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same as above

public abstract class AllSegmentsWalkerBase<T, TSegment> : AllSegmentsWalkerBase
where TSegment : Segment<T>
{
/// <summary>
/// <para>
/// The minimum string segment length.
/// </para>
/// <para></para>
/// <para>A read-only field that represents the minimum length of the sequence segment.</para>
/// <para>Поле только для чтения, которое представляет минимальную длину сегмента последовательности.</para>
/// </summary>
private readonly int _minimumStringSegmentLength;

/// <summary>
/// <para>
/// Initializes a new <see cref="AllSegmentsWalkerBase"/> instance.
/// </para>
/// <para></para>
/// <para>Constructor that initializes the field <see cref="_minimumStringSegmentLength"/>, inserts the default value there.</para>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check how dotnet documentate their constructors: FileStream constructors

/// <para>Конструктор, который инициализирует поле <see cref="_minimumStringSegmentLength"/> , вставляет туда значение по умолчанию.</para>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same as above

/// </summary>
/// <param name="minimumStringSegmentLength">
/// <para>A minimum string segment length.</para>
/// <para></para>
/// <para>The parameter that takes a field <see cref="DefaultMinimumStringSegmentLength"/>.</para>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description is not descriptive. Check how microsoft documentate parameters

/// <para>Параметр, принимающий поле <see cref="DefaultMinimumStringSegmentLength"/>.</para>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same as above

/// </param>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
protected AllSegmentsWalkerBase(int minimumStringSegmentLength) => _minimumStringSegmentLength = minimumStringSegmentLength;

/// <summary>
/// <para>
/// Initializes a new <see cref="AllSegmentsWalkerBase"/> instance.
/// </para>
/// <para></para>
/// <para>Constructor referencing another constructor by passing a field to its parameter <see cref="DefaultMinimumStringSegmentLength"/>.</para>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same as above

/// <para>Конструктор, ссылающийся на другой конструктор, передавая в его параметр поле <see cref="DefaultMinimumStringSegmentLength"/>.</para>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Конструктор, ссылающийся на свою перегрузку, передавая в его параметр поле

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same as above

/// </summary>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
protected AllSegmentsWalkerBase() : this(DefaultMinimumStringSegmentLength) { }
Expand Down Expand Up @@ -71,23 +64,23 @@ public virtual void WalkAll(IList<T> elements)
/// <para>
/// Creates the segment using the specified elements.
/// </para>
/// <para></para>
/// <para>Представляет базовый метод, для всех методов создания мегмента.</para>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This translation is not correct

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This documentation is incorrect. Check any documentation of abstract classes: Stream abstract class and its methods

/// </summary>
/// <param name="elements">
/// <para>The elements.</para>
/// <para></para>
/// <para>A list of elements.</para>
/// <para>Список элементов.</para>
/// </param>
/// <param name="offset">
/// <para>The offset.</para>
/// <para></para>
/// <para>An offset relative to the <paramref name="elements"/> sequence from which the segment starts.</para>
/// <para>Смещение относительно списка <paramref name="elements"/>, с которого начинается сегмент.</para>
/// </param>
/// <param name="length">
/// <para>The length.</para>
/// <para></para>
/// <param name="length">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete extra space

/// <para>A segment's length.</para>
/// <para>Длина сегмента.</para>
/// </param>
/// <returns>
/// <para>The segment</para>
/// <para></para>
/// <para>Created megment</para>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is an article?

/// <para>Созданный мегмент</para>
/// </returns>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
protected abstract TSegment CreateSegment(IList<T> elements, int offset, int length);
Expand All @@ -96,7 +89,7 @@ public virtual void WalkAll(IList<T> elements)
/// <para>
/// Iterations the segment.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description is not complete

/// </para>
/// <para></para>
/// <para>Представляет базоый метод, для всех методов итерации.</para>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This documentation is incorrect. Check any documentation of abstract classes: Stream abstract class and its methods

/// </summary>
/// <param name="segment">
/// <para>The segment.</para>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description is not complete

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,37 +6,38 @@
namespace Platform.Collections.Segments.Walkers
{
/// <summary>
/// <para>
/// Represents the all segments walker base.
/// </para>
/// <para></para>
/// <para>Represents the base class for walkers through all possible segments of a sequence.</para>
/// <para>Представляет базовый класс для проходчиков по всем возможным сегментам последовательности.</para>
/// </summary>
/// <seealso cref="AllSegmentsWalkerBase{T, Segment{T}}"/>
Konard marked this conversation as resolved.
Show resolved Hide resolved
/// <seealso cref="AllSegmentsWalkerBase"/>
/// <typeparam name="T">
/// <para>The sequence's element type.</para>
/// <para>Тип элемента последовательности.</para>
/// </typeparam>
public abstract class AllSegmentsWalkerBase<T> : AllSegmentsWalkerBase<T, Segment<T>>
FreePhoenix888 marked this conversation as resolved.
Show resolved Hide resolved
{
/// <summary>
/// <para>
/// Creates the segment using the specified elements.
/// </para>
/// <para></para>
/// <para>Create a new instance of the <see cref="Segment{T}"/> class based on <paramref name="elements"/> sequence.</para>
/// <para>Создаёт новый экземпляр класса <see cref="Segment{T}"/> на основе последовательности <paramref name="elements"/>.</para>
/// </summary>
/// <param name="elements">
/// <para>The elements.</para>
/// <para></para>
/// <para>A list of elements.</para>
/// <para>Список элементов.</para>
/// </param>
/// <param name="offset">
/// <para>The offset.</para>
/// <para></para>
/// <para>An offset relative to the <paramref name="elements"/> sequence from which the segment starts.</para>
/// <para>Смещение относительно списка <paramref name="elements"/>, с которого начинается сегмент.</para>
TwinkmrMask marked this conversation as resolved.
Show resolved Hide resolved
/// </param>
/// <param name="length">
/// <para>The length.</para>
/// <para></para>
/// <para>A segment's length.</para>
/// <para>Длина сегмента.</para>
/// </param>
/// <returns>
/// <para>A segment of t</para>
/// <para></para>
/// <para>An instance of the <see cref="Segment{T}"/> class.</para>
/// <para>Экземпляр класса <see cref="Segment{T}"/>.</para>
Konard marked this conversation as resolved.
Show resolved Hide resolved
/// </returns>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
protected override Segment<T> CreateSegment(IList<T> elements, int offset, int length) => new Segment<T>(elements, offset, length);
}
}
}