New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vetka2 #124

Open

Hole-code wants to merge 18 commits into main from vetka2

Contributor

Hole-code commented Jun 23, 2021

No description provided.

Hole-code added 8 commits

June 23, 2021 22:15


          add t...

cc700fa


          Added Template for second method

56e820f


          Added Template for second method2

e0895eb


          Added Template for second method2

6e0e5f2


          Added Template for second method3

b43a1d1


          Added Template for second method3

897505f


          Added Template for second method4

b58687a


          Added Template for second method5

b34c7e5

TwinkmrMask requested review from TwinkmrMask and Konard

June 23, 2021 19:30

Member

TwinkmrMask commented Jun 23, 2021 •

edited

Loading

You need to put dots at the end of comments, as well as use the word element in the plural, since we are talking about a whole collection.


          Corrected errors, added commentary for second method

881a3b3

TwinkmrMask reviewed

View reviewed changes

Member

TwinkmrMask left a comment

In some places, your mistakes are repeated, find them yourself, I will not show them to everyone

csharp/Platform.Collections/ICollectionExtensions.cs Outdated

@@ @@ -16,17 +16,37 @@ public static class ICollectionExtensions @@
                       /// <para>Checking collection for empty.</para>
                       /// <para>Проверяет коллекцию на пустоту.</para>
                       /// </summary>
+                      /// <typeparam name="T">
+                      /// <para>Collection element data type.</para>

Member

TwinkmrMask Jun 24, 2021 •

edited

Loading

The elements collection data type. may be.

csharp/Platform.Collections/ICollectionExtensions.cs Outdated

                       /// <param name="collection">
                       /// <para>Method takes an elements collection of <see cref="ICollection<T>"/> type.</para>
-                      /// <para>Метода принимает колекцию элементов <see cref="ICollection<T>"/> типа.</para>
+                      /// <para>Метод принимает колекцию элементов <see cref="ICollection<T>"/> типа.</para>

Member

TwinkmrMask Jun 24, 2021 •

edited

Loading

You shouldn't say that this is a method, just write what it does
You need to remove the word Method

csharp/Platform.Collections/ICollectionExtensions.cs Outdated

+                      /// <summary>
+                      /// <para>Checks if all elements of the collection are standard values of type.</para>
+                      /// <para>Проверяет являются ли все элементы коллекции значениями по умолчанию типа.</para>

Member

TwinkmrMask Jun 24, 2021 •

edited

Loading

You can say <see cref="default"/> instead are standard values of type.

csharp/Platform.Collections/ICollectionExtensions.cs Outdated

                       /// </param>
                       /// <returns>
-                      /// <para>Returns a <see cref="bool"/> type variable equal to False if the collection is empty else returns true.</para>
+                      /// <para>Returns a <see cref="bool"/> type variable equal to false if the collection is empty else returns true.</para>

Member

TwinkmrMask Jun 24, 2021

You can say just The <see cref="bool"/> type variable equal to false if the collection is empty else returns true.


          Corrected errors2

a651140

TwinkmrMask reviewed

View reviewed changes

Member

TwinkmrMask left a comment

You left one mistake

csharp/Platform.Collections/ICollectionExtensions.cs Outdated

@@ @@ -17,23 +17,23 @@ public static class ICollectionExtensions @@
                       /// <para>Проверяет коллекцию на пустоту.</para>
                       /// </summary>
                       /// <typeparam name="T">
-                      /// <para>Collection element data type.</para>
+                      /// <para>Collection elements data type.</para>

Member

TwinkmrMask Jun 24, 2021 •

edited

Loading

Ah shit, here we go again

Member

TwinkmrMask Jun 24, 2021

Also you made a mistake in the translation into Russian

csharp/Platform.Collections/ICollectionExtensions.cs Outdated

                       /// <para>Тип данных элемента коллекций.</para>
                       /// </typeparam>
                       /// <param name="collection">
-                      /// <para>Method takes an elements collection of <see cref="ICollection<T>"/> type.</para>
-                      /// <para>Метод принимает колекцию элементов <see cref="ICollection<T>"/> типа.</para>
+                      /// <para>Takes an elements collection of <see cref="ICollection<T>"/> type.</para>

Member

TwinkmrMask Jun 24, 2021

Good

csharp/Platform.Collections/ICollectionExtensions.cs

                       /// </param>
                       /// <returns>
-                      /// <para>Returns a <see cref="bool"/> type variable equal to false if the collection is empty else returns true.</para>
-                      /// <para>Возвращает переменную типа <see cref="bool"/> равной false если коллекция пустая иначе возвращает true.</para>
+                      /// <para>The <see cref="bool"/> type variable equal to false if the collection is empty else returns true.</para>

Member

TwinkmrMask Jun 24, 2021

Good

Member

FreePhoenix888 Jun 25, 2021

The <see cref="bool"/> type variable equal to false if the collection is empty else returns true.->A <see cref="bool"/> value that determines whether the collection is empty.

csharp/Platform.Collections/ICollectionExtensions.cs Outdated

                       /// </returns>
                       [MethodImpl(MethodImplOptions.AggressiveInlining)]
                       public static bool IsNullOrEmpty<T>(this ICollection<T> collection) => collection == null || collection.Count == 0;
                       /// <summary>
-                      /// <para>Checks if all elements of the collection are standard values of type.</para>
-                      /// <para>Проверяет являются ли все элементы коллекции значениями по умолчанию типа.</para>
+                      /// <para>Checks if all elements of the collection <see cref="default"/>.</para>

Member

TwinkmrMask Jun 24, 2021

Good

Hole-code added 8 commits

June 24, 2021 18:52


          Corrected errors3

9030efa


          Corrected errors4

0742ed8


          Corrected errors5


          Corrected errors6

f52250a


          Corrected errors7

e686a1d


          Corrected errors8

2d2c8cc


          Corrected errors9

c0a79e7


          Corrected errors10

eb1d586

FreePhoenix888 reviewed

View reviewed changes

csharp/Platform.Collections/ICollectionExtensions.cs

+                      /// <para>Коллекция для проверки.</para>
+                      /// </param>
+                      /// <returns>
+                      /// <para>Returns a variable of type <see cref="bool"/> equal to true if all elements in the collection are default values else returns false.</para>

Member

FreePhoenix888 Jun 25, 2021 •

edited

Loading

Returns a variable of type <see cref="bool"/> equal to true if all elements in the collection are default values else returns false. -> Gets a <see cref="bool"/> value that determines whether all collection elements values are equal to the default values.

FreePhoenix888 reviewed

View reviewed changes

csharp/Platform.Collections/ICollectionExtensions.cs

+                      /// </param>
+                      /// <returns>
+                      /// <para>Returns a variable of type <see cref="bool"/> equal to true if all elements in the collection are default values else returns false.</para>
+                      /// <para>Возвращает переменную типа <see cref="bool"/> равной true если все элементы коллекции являются значениями по умолчанию иначе возвращает false.</para>

Member

FreePhoenix888 Jun 25, 2021 •

edited

Loading

Возвращает переменную типа <see cref="bool"/> равной true если все элементы коллекции являются значениями по умолчанию иначе возвращает false.->Возвращает значение типа <see cref="bool"/>, определяющее, равны ли все значения элементов коллекции <see cref="default"/> значениям.

FreePhoenix888 reviewed

View reviewed changes

csharp/Platform.Collections/ICollectionExtensions.cs



		/// <summary>
		/// <para>Checks if all elements of the collection.<see cref="default"/>.</para>

Member

FreePhoenix888 Jun 25, 2021 •

edited

Loading

Checks if all elements of the collection.<see cref="default"/>. ->Checks if all collection elements values are equal to the <see cref="default"/> values.

FreePhoenix888 reviewed

View reviewed changes

csharp/Platform.Collections/ICollectionExtensions.cs

+                      /// <summary>
+                      /// <para>Checks if all elements of the collection.<see cref="default"/>.</para>
+                      /// <para>Проверяет являются ли все элементы коллекции.<see cref="default"/>.</para>

Member

FreePhoenix888 Jun 25, 2021 •

edited

Loading

Проверяет являются ли все элементы коллекции.<see cref="default"/>.->Проверяет равны ли все значения элементов коллекции <see cref="default"/> значениям.

FreePhoenix888 reviewed

View reviewed changes

csharp/Platform.Collections/ICollectionExtensions.cs

    
                      /// <para>Returns a <see cref="bool"/> type variable equal to False if the collection is empty else returns true.</para>

                      /// <para>Возвращает переменную типа <see cref="bool"/> равной false если коллекция пустая иначе возвращает true.</para>

                      /// <para>The <see cref="bool"/> type variable equal to false if the collection is empty else returns true.</para>

                      /// <para>Переменная типа <see cref="bool"/> равна false, если коллекция пуста, иначе возвращает true.</para>

Member

FreePhoenix888 Jun 25, 2021

Переменная типа <see cref="bool"/> равна false, если коллекция пуста, иначе возвращает true.->Значение типа <see cref="bool"/>, определяющее, пуста ли коллекция.

TwinkmrMask reviewed

View reviewed changes

csharp/Platform.Collections/ICollectionExtensions.cs Outdated

+                      /// <para>Проверяет являются ли все элементы коллекции значениями по умолчанию типа.</para>
+                      /// </summary>
+                      /// <typeparam name="T">
+                      /// <para>Collection elements data type.</para>

Member

TwinkmrMask Aug 10, 2021

Here you have a collection in the singular

csharp/Platform.Collections/ICollectionExtensions.cs Outdated

+                      /// </summary>
+                      /// <typeparam name="T">
+                      /// <para>Collection elements data type.</para>
+                      /// <para>Тип данных элементов коллекций.</para>

Member

TwinkmrMask Aug 10, 2021

And here is a collection in the plural, please decide

csharp/Platform.Collections/ICollectionExtensions.cs Outdated Show resolved Hide resolved

FreePhoenix888 changed the base branch from master to main

March 27, 2022 07:14

FreePhoenix888 mentioned this pull request

Change organization pull requests base branch from master to main linksplatform/Data.Doublets#340

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet