Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading yaml is actually really slow in pure python! and we load a lot of yaml!
There's a free perf boost we can get by just using the compiled yamllib versions if they are available (they usually are).
The only failure I noticed was that there was a single
\t
character at the start of a multiline string in the biolink model that cause s parsing error, but once that was fixed it was exactly the same just way faster.For
YAMLLoader.load_as_dict
in mainlinkml
tests, (cumulative time in seconds,--with-slow
)load_as_dict
all ~ for free ~
Same as #307 , i have no idea why these tests are failing. i didn't touch anything near that test, and this is a totally orthogonal change to 307 having the same error, and one of the tests here miraculously passed, so i think this is a flaky test rather than anything I did.