Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typos in schemview.py functions: delete_enum(), delete_slot(), delete_subset() #301

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

puja-trivedi
Copy link

@puja-trivedi puja-trivedi commented Feb 21, 2024

When using the functions delete_enum, delete_slot, and delete_subset I was getting these errors:

  1. AttributeError: 'SchemaDefinition' object has no attribute 'enumes'.
    Which traces back to line 1663, in delete_enum: del self.schema.enumes[enum_name]

2. AttributeError: 'SchemaDefinition' object has no attribute 'slotes'.
Which traces back to line 1655, in delete_slot: del self.schema.slotes[slot_name]

  1. AttributeError: 'SchemaDefinition' object has no attribute 'subsetes'.
    Which traces back to line 1679, in delete_subset: del self.schema.subsetes[subset_name]

When I change enumes to enums, slotes to slots, and subsetes to subsets the functions seem to work as expected.

… slots, enumes -> enums, subsetes -> subsets)
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (51d2fce) 62.80% compared to head (a959a20) 62.90%.
Report is 5 commits behind head on main.

Files Patch % Lines
linkml_runtime/utils/schemaview.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
+ Coverage   62.80%   62.90%   +0.10%     
==========================================
  Files          61       62       +1     
  Lines        8506     8529      +23     
  Branches     2239     2239              
==========================================
+ Hits         5342     5365      +23     
- Misses       2553     2554       +1     
+ Partials      611      610       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmungall cmungall merged commit 16cdeb9 into linkml:main Feb 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants