Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning in regex #289

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Fix warning in regex #289

merged 1 commit into from
Dec 13, 2023

Conversation

cthoyt
Copy link
Contributor

@cthoyt cthoyt commented Dec 5, 2023

I get warnings like the following because there's an unescaped slash. It either needs to be \\. or make the string a raw string, which is preferred for regex legibility.

.venv/lib/python3.10/site-packages/linkml_runtime/utils/pattern.py:34
  /home/runner/work/go-fastapi/go-fastapi/.venv/lib/python3.10/site-packages/linkml_runtime/utils/pattern.py:34: DeprecationWarning: invalid escape sequence '\.'
    var_name = re.compile("{([a-z0-9_-]+([\.-_ ][a-z0-9]+)*)}", re.IGNORECASE)

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d45970a) 62.09% compared to head (b6faaa9) 62.09%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #289   +/-   ##
=======================================
  Coverage   62.09%   62.09%           
=======================================
  Files          63       63           
  Lines        8461     8461           
  Branches     2170     2170           
=======================================
  Hits         5254     5254           
  Misses       2599     2599           
  Partials      608      608           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sierra-moxon sierra-moxon requested review from Silvanoc and sierra-moxon and removed request for Silvanoc December 13, 2023 21:58
@sierra-moxon sierra-moxon merged commit 476d237 into linkml:main Dec 13, 2023
8 checks passed
@cthoyt cthoyt deleted the patch-1 branch December 13, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants