fix: add support for urns to curie namespaces #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #287 +/- ##
==========================================
+ Coverage 62.09% 62.12% +0.02%
==========================================
Files 63 63
Lines 8461 8462 +1
Branches 2170 2170
==========================================
+ Hits 5254 5257 +3
+ Misses 2599 2598 -1
+ Partials 608 607 -1
☔ View full report in Codecov by Sentry. |
Support for URNs added on version v1.6.1 (later fixed on v1.6.2) is missing support for proper CURIE conversion for URNs. This patch fixes it. It also provides a test-case. Signed-off-by: Silvano Cirujano Cuesta <[email protected]>
Silvanoc
force-pushed
the
fix-urn-usage
branch
from
309e446
to
dee0311
Compare
sierra-moxon
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for URNs added on version v1.6.1 (later fixed on v1.6.2) is missing support for proper CURIE conversion for URNs. This patch fixes it.
It also provides a test-case.