test: improve coverage of curie validation #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue linkml/linkml#1701 has discovered an erroneous validation of CURIE prefixes, since apparently it doesn't accept characters '_' and '.'. This patch extends the tests to provide test coverage for the expected values to work, avoiding future regressions. Signed-off-by: Silvano Cirujano Cuesta <[email protected]>
Signed-off-by: Silvano Cirujano Cuesta <[email protected]>
For whatever strange reasons, the regular expressions being used for CURIE validation were using UTF-8 non-breaking spaces (hex C2A0) instead of normal whitespaces. This patch fixes it. Signed-off-by: Silvano Cirujano Cuesta <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
=======================================
Coverage 62.09% 62.09%
=======================================
Files 63 63
Lines 8461 8461
Branches 2170 2170
=======================================
Hits 5254 5254
Misses 2599 2599
Partials 608 608
☔ View full report in Codecov by Sentry. |
Signed-off-by: Silvano Cirujano Cuesta <[email protected]>
|
Commit 38c4be2 explains the issue. The regular expressions were right! Only some strange UTF-8 non-breaking spaces instead of whitespaces had appeared in the code and were breaking the regexs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According issue linkml/linkml#1701 apparently legal CURIEs like
WIKIDATA_PROPERTY:P854andWIKIDATA.PROPERTY:P854are being rejected by the validation module.This PR provides:
Closes linkml/linkml#1701.