Merge pull request #341 from linki/pod-deleted-metric

Add namespace metadata to deleted pods metric
linki · Jun 7, 2021 · d1b517d · d1b517d
2 parents e6f421d + 0dacb85
commit d1b517d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/chaoskube/chaoskube.go b/chaoskube/chaoskube.go
@@ -261,7 +261,7 @@ func (c *Chaoskube) DeletePod(ctx context.Context, victim v1.Pod) error {
 		return err
 	}
 
-	metrics.PodsDeletedTotal.Inc()
+	metrics.PodsDeletedTotal.WithLabelValues(victim.Namespace).Inc()
 
 	ref, err := reference.GetReference(scheme.Scheme, &victim)
 	if err != nil {

diff --git a/metrics/metrics.go b/metrics/metrics.go
@@ -7,11 +7,11 @@ import (
 
 var (
 	// PodsDeletedTotal is the total number of deleted pods.
-	PodsDeletedTotal = promauto.NewCounter(prometheus.CounterOpts{
+	PodsDeletedTotal = promauto.NewCounterVec(prometheus.CounterOpts{
 		Namespace: "chaoskube",
 		Name:      "pods_deleted_total",
 		Help:      "The total number of pods deleted",
-	})
+	}, []string{"namespace"})
 	// IntervalsTotal is the total number of intervals, i.e. call to Run().
 	IntervalsTotal = promauto.NewCounter(prometheus.CounterOpts{
 		Namespace: "chaoskube",