update ServiceProfile compat warning #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the HTTPRoute/ServiceProfile incompatibility warning in the documentation to use the new wording suggested by @wmorgan in #1657 (comment).
kflynn
requested changes
Aug 21, 2023
| [ServiceProfile](../../features/service-profiles/) is also defined for that | ||
| Service, proxies will use the ServiceProfile configuration, rather than the | ||
| HTTPRoute configuration, as long as the ServiceProfile exists. | ||
| **Outbound HTTPRoutes and [ServiceProfile]s provide overlapping configuration.** |
There was a problem hiding this comment.
Huh. This is rendering as
Outbound HTTPRoutes and [ServiceProfile]s provide...
in the Netlify preview? This is weird to me because I thought I checked the preview for your other PR, but... yeah, maybe doublecheck that? 🤔 🙁
There was a problem hiding this comment.
gah, whoops --- i think i forgot to add a link reference in this one
There was a problem hiding this comment.
turns out this is the same problem as #1662 (comment) 🙃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the HTTPRoute/ServiceProfile incompatibility warning in the documentation to use the new wording suggested by @wmorgan in #1657 (comment).