Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention is to make group IDs configurable. I opened an issue in order to target this. Before working on the respective changes in the linkerd2 repo I thought it would make sense to get this feature implemented here first.
This pull request adds the option to set the group ID via command line and via annotation. The tests available via
just
ran successfully in the dev container and some manual tests also ran well. I had to tweak my setup a little bit in order to make it work in WSL2 behind an HTTP proxy, so my setup might differ from the reference setup. Still, I assume that my tweaks did not have an impact on the outcome of the tests. It is also worth mentioning that tweaking IP tables manually is not part of my daily business. I just mention it for the reviewers to pay special attention. Thanks in advance for the review. Looking forward to this feature getting merged.