Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] fix restartServerByDeletingSSTFiles tests with checksum enabled #825

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

m-nagarajan
Copy link
Contributor

Summary

This test originally had the following flow:

  • Delete the SST files.
  • Restart the servers to simulate a crash and restart in the midst of SST file move.

However, this flow introduced an issue when checksum was enabled:
Graceful shutdown of the server after SST file deletion triggers a final offset sync, which throws an exception when files are missing during checksum calculations.

Modified the test to:
Stop the server -> Delete the SST files -> Start the server.

How was this PR tested?

GH CI

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • [] Yes. Make sure to explain your proposed changes and call out the behavior change.

Copy link
Collaborator

@adamxchen adamxchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graceful shutdown of the server after SST file deletion triggers a final offset sync, which throws an exception when files are missing during checksum calculations.

Can you add one more test (either a unit test or integ test) to test this path?

@sixpluszero
Copy link
Contributor

Graceful shutdown of the server after SST file deletion triggers a final offset sync, which throws an exception when files are missing during checksum calculations.

Can you add one more test (either a unit test or integ test) to test this path?

I think the change itself is good. Regarding the suggestion by Adam, I think it is OK to have it to validate the final sync() action as you mentioned.

Nit: Is it possible to merge the non-aa test with the A/A test with some test parameters? Not necessarily need to happen in this PR if you think it is complicated but I suppose it can just be turned off by setting store to A/A = false?

@m-nagarajan
Copy link
Contributor Author

@adamxchen @sixpluszero added more unit tests, please take another look.

Copy link
Contributor

@sixpluszero sixpluszero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@m-nagarajan m-nagarajan merged commit 4f11a4a into linkedin:main Feb 1, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants