Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[changelog] Patch topic dumper to work on change capture topics #746

Merged
merged 1 commit into from
Nov 13, 2023
Merged

[changelog] Patch topic dumper to work on change capture topics #746

merged 1 commit into from
Nov 13, 2023

Conversation

ZacAttack
Copy link
Contributor

@ZacAttack ZacAttack commented Nov 10, 2023 •
edited
Loading

[changelog] Patch topic dumper to work on change capture topics

Previously, the topic dumper only worked on RT and version topics, now this should work on SR
and CC topics.

How was this PR tested?

In production!

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

haoxu07
haoxu07 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@haoxu07 haoxu07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ZacAttack ZacAttack merged commit a420879 into linkedin:main Nov 13, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoxu07 haoxu07 haoxu07 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZacAttack @haoxu07