Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[producer] Fixed NPE in UpdateBuilderImpl::validateUpdateRecordIsSerializable #740

Merged
merged 2 commits into from
Nov 6, 2023
Merged

[producer] Fixed NPE in UpdateBuilderImpl::validateUpdateRecordIsSerializable #740

merged 2 commits into from
Nov 6, 2023

Conversation

FelixGV
Copy link
Contributor

@FelixGV FelixGV commented Nov 6, 2023

Also expanded unit test.

How was this PR tested?

Unit test.

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

@FelixGV FelixGV enabled auto-merge (squash) November 6, 2023 18:22
majisourav99
majisourav99 approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@majisourav99 majisourav99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Felix

@FelixGV FelixGV merged commit d03f184 into linkedin:main Nov 6, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majisourav99 majisourav99 majisourav99 approved these changes

@nisargthakkar nisargthakkar nisargthakkar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FelixGV @nisargthakkar @majisourav99