[admin-tool] Enable venice-admin-tool to parse JSON map arguments from command line #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…valid and invalid JSON arguments
elijahgrimaldi
changed the title
nisargthakkar
requested changes
Nov 4, 2023
internal/venice-common/src/main/java/com/linkedin/venice/utils/Utils.java
Show resolved
Hide resolved
internal/venice-common/src/main/java/com/linkedin/venice/utils/Utils.java
Outdated
Show resolved
Hide resolved
internal/venice-common/src/main/java/com/linkedin/venice/utils/Utils.java
Outdated
Show resolved
Hide resolved
internal/venice-common/src/main/java/com/linkedin/venice/utils/Utils.java
Outdated
Show resolved
Hide resolved
internal/venice-common/src/test/java/com/linkedin/venice/utils/UtilsTest.java
Outdated
Show resolved
Hide resolved
internal/venice-common/src/main/java/com/linkedin/venice/utils/Utils.java
Outdated
Show resolved
Hide resolved
internal/venice-common/src/test/java/com/linkedin/venice/utils/UtilsTest.java
Outdated
Show resolved
Hide resolved
internal/venice-common/src/test/java/com/linkedin/venice/utils/UtilsTest.java
Outdated
Show resolved
Hide resolved
internal/venice-common/src/test/java/com/linkedin/venice/utils/UtilsTest.java
Outdated
Show resolved
Hide resolved
internal/venice-common/src/test/java/com/linkedin/venice/utils/UtilsTest.java
Outdated
Show resolved
Hide resolved
nisargthakkar
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
LGTM
Thanks a lot for the contribution @elijahgrimaldi. Great job.
I have a suggestion for future PRs. Can you please try to keep the pull request template? For this PR, I have updated the PR description to demonstrate the format that we expect the PR description to follow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable venice-admin-tool to parse JSON map arguments from command line
Added correct JSON parsing for command line inputs to admin-tool to read maps as JSON
Resolves #647
How was this PR tested?
CI
Does this PR introduce any user-facing changes?