[changelog][server] Fix incoming write schema id #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to fix a WC/schema evolution bug. Tests to follow. But the changecapture should contain the schema of the merge result which should be the superset schema not the write compute one.
FelixGV
reviewed
Nov 3, 2023
...client/src/main/java/com/linkedin/davinci/kafka/consumer/ActiveActiveStoreIngestionTask.java
Outdated
Show resolved
Hide resolved
FelixGV
reviewed
Nov 4, 2023
...da-vinci-client/src/main/java/com/linkedin/davinci/consumer/VeniceChangelogConsumerImpl.java
Show resolved
Hide resolved
...-client/src/main/java/com/linkedin/davinci/storage/chunking/AbstractAvroChunkingAdapter.java
Outdated
Show resolved
Hide resolved
...s/da-vinci-client/src/main/java/com/linkedin/davinci/store/record/ByteBufferValueRecord.java
Outdated
Show resolved
Hide resolved
...client/src/main/java/com/linkedin/davinci/kafka/consumer/ActiveActiveStoreIngestionTask.java
Outdated
Show resolved
Hide resolved
|
So... I think we need to do some code coverage for this 🤷 ... |
Fixed |
FelixGV
added a commit
to FelixGV/venice
that referenced
this pull request
Nov 20, 2023
This fixes a regression introduced in PR linkedin#735.
2 tasks
FelixGV
added a commit
that referenced
this pull request
Nov 20, 2023
This fixes a regression introduced in PR #735.
2 tasks
sixpluszero
added a commit
that referenced
this pull request
Nov 21, 2023
This fixes a regression introduced in PR #735.
m-nagarajan
pushed a commit
to m-nagarajan/venice
that referenced
this pull request
Nov 28, 2023
This fixes a regression introduced in PR linkedin#735.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix a WC/schema evolution bug. Tests to follow. But the changecapture should contain the schema of the merge result which should be the superset schema not the write compute one.
Summary, imperative, start upper case, don't end with a period
Resolves #XXX
How was this PR tested?
Does this PR introduce any user-facing changes?