Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Tweak logs for better debugging #725

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

adamxchen
Copy link
Collaborator

@adamxchen adamxchen commented Oct 31, 2023

Summary, imperative, start upper case, don't end with a period

During my oncall shifts, I find the logging to detect non-existing topics is a bit noisy and doesn't provide much information when we filter by ERROR. It should be WARNING.

Also, sometimes I see stats failed to register but there was no reason. Add that as well.

How was this PR tested?

ghci.

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

Copy link
Contributor

@lluwm lluwm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@adamxchen adamxchen merged commit 714620d into linkedin:main Nov 28, 2023
31 checks passed
m-nagarajan pushed a commit to m-nagarajan/venice that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants