[vpj] VPJ should not close and release resources on its own #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisargthakkar
commented
Oct 31, 2023
clients/venice-push-job/src/main/java/com/linkedin/venice/hadoop/VenicePushJob.java
Show resolved
Hide resolved
|
Leaving in draft phase till all release blockers are resolved. This is not high priority |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VPJ should not close and release resources on its own
VPJ with D2 fails to send final push job details to controller because VPJ internally closes the D2 client and the subsequent
ControllerClientrequest fails. The URL based ControllerClient doesn't have this issue because theclosemethod is essentially a no-op.How was this PR tested?
GH CI
Does this PR introduce any user-facing changes?