Bump netty version to 4.1.74.Final #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelixGV
reviewed
Oct 25, 2023
nisargthakkar
approved these changes
Oct 25, 2023
majisourav99
force-pushed
the
nettybump
branch
from
fe0b2ef
to
58421d6
Compare
majisourav99
force-pushed
the
nettybump
branch
from
58421d6
to
8164f85
Compare
|
Anyone knows why Github has not been requiring fresh approvals when new commits are pushed? |
|
Guess unless there is no new diff in the new commit, it wont ask for approval.
From: Nisarg Thakkar ***@***.***>
Date: Thursday, October 26, 2023 at 2:05 PM
To: linkedin/venice ***@***.***>
Cc: Sourav Maji ***@***.***>, Author ***@***.***>
Subject: Re: [linkedin/venice] Bump netty version to 4.1.74.Final (PR #715)
Anyone knows why Github has not been requiring fresh approvals when new commits are pushed?
—
Reply to this email directly, view it on GitHub<#715 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AO6HTKJOIQLD5SSOGLRZMUDYBLF6XAVCNFSM6AAAAAA6PU7GKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBRHA4TEMZYGM>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I changed the branch protection rules to align with @sushantmane's PR #716. Maybe I messed things up...? |
|
I think this has been the case before the change to the rules. I noticed it yesterday too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump netty version to 4.1.74.Final
Bump netty version to 4.1.74.Final
How was this PR tested?
GHCI
Does this PR introduce any user-facing changes?