[controller][test] Fix race condition during controller startup and fix flakies #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sushantmane
changed the title
FelixGV
previously approved these changes
Oct 25, 2023
FelixGV
reviewed
Oct 25, 2023
services/venice-controller/src/main/java/com/linkedin/venice/controller/VeniceHelixAdmin.java
Outdated
Show resolved
Hide resolved
…everal flakies/reduce noise - Setup admin topic for a cluster before running cluster initialization routines - Do not refuse to return real time topic if store being setup is of type system store - Close cluster wrapper at the end of test in `PartialUpdateClusterConfigTest` - Close local broker created during `TestActiveActiveIngestion::testAAIngestionWithStoreView` - Use `volatile` `PubSubProducerAdapter::forceClosed` flag to make update visible to a callback thread - Use unique data paths for venice-server-data in `AbstractClientEndToEndSetup` to avoid race condition
sushantmane
force-pushed
the
li-sync-controller-startup
branch
from
09c4a98
to
ea92e59
Compare
...-common/src/integrationTest/java/com/linkedin/venice/endToEnd/TestActiveActiveIngestion.java
Outdated
Show resolved
Hide resolved
...common/src/integrationTest/java/com/linkedin/venice/endToEnd/TestChangeCaptureIngestion.java
Outdated
Show resolved
Hide resolved
|
Thanks for the review, @FelixGV & @nisargthakkar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix race condition during controller startup and fix flakies/reduce noise
PartialUpdateClusterConfigTestTestActiveActiveIngestion::testAAIngestionWithStoreViewvolatilePubSubProducerAdapter::forceClosedflag to make update visible to a callback threadAbstractClientEndToEndSetupto avoid race conditionHow was this PR tested?
Internal CI and GHCI
Does this PR introduce any user-facing changes?