[server][controller][vpj] Support TTL repush for A/A + partial update #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamxchen
reviewed
Oct 19, 2023
...ce-push-job/src/main/java/com/linkedin/venice/hadoop/input/kafka/ttl/VeniceRmdTTLFilter.java
Outdated
Show resolved
Hide resolved
...ce-push-job/src/main/java/com/linkedin/venice/hadoop/input/kafka/ttl/VeniceRmdTTLFilter.java
Outdated
Show resolved
Hide resolved
clients/venice-push-job/src/main/java/com/linkedin/venice/hadoop/VenicePushJob.java
Show resolved
Hide resolved
...ce-push-job/src/main/java/com/linkedin/venice/hadoop/input/kafka/ttl/VeniceRmdTTLFilter.java
Outdated
Show resolved
Hide resolved
...ce-push-job/src/main/java/com/linkedin/venice/hadoop/input/kafka/ttl/VeniceRmdTTLFilter.java
Outdated
Show resolved
Hide resolved
sixpluszero
force-pushed
the
TTLrepsuhAAWC
branch
from
40dc979
to
be8b32c
Compare
majisourav99
approved these changes
Oct 25, 2023
2 tasks
sixpluszero
added a commit
that referenced
this pull request
Oct 31, 2023
…that impacts controllerClient#getAllReplicationMetadataSchemas() (#719) As a side-effect in PR: #704 I changed the Json property in controller class SchemaRoutes and MultiSchemaResponse to try to clean up API naming to make it makes more sense - ID-RMD_VERSION_ID. This leads to breaking changes in controller, it needs controller deployment to release VPJ and it might have break the API JSON serialization/deserialization. To make it easy to release the new TTL repush AAWC feature, this PR reverts the part of the change, so it no longer requires controller deployment. I will try to make another attempt apart from this PR to gracefully deprecate improper naming of JSON property.
elijahgrimaldi
pushed a commit
to elijahgrimaldi/venice
that referenced
this pull request
Nov 1, 2023
…that impacts controllerClient#getAllReplicationMetadataSchemas() (linkedin#719) As a side-effect in PR: linkedin#704 I changed the Json property in controller class SchemaRoutes and MultiSchemaResponse to try to clean up API naming to make it makes more sense - ID-RMD_VERSION_ID. This leads to breaking changes in controller, it needs controller deployment to release VPJ and it might have break the API JSON serialization/deserialization. To make it easy to release the new TTL repush AAWC feature, this PR reverts the part of the change, so it no longer requires controller deployment. I will try to make another attempt apart from this PR to gracefully deprecate improper naming of JSON property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[server][controller][vpj] Support TTL repush for A/A + partial update
This PR aims to add TTL repush support for Active/Active with partial update enabled case.
TTL repush filters record by looking at the timestamp in the RMD metadata. For A/A only store which should be using value level TS, it will directly compare long value. For A/A + partial update (AAWC) store, it is supposed to be suing field level TS, it will rely on MergeRecordHelper#deleteRecord API to perform a dummy deletion to filter out stale parts (or drop the record if every field is more stale than the threshold).
This PR also did some small code cleanup and refactor of the related functionalities and fixed some JavaDoc.
How was this PR tested?
Existing unit tests and integration tests, will also add new unit test and integration tests.
Does this PR introduce any user-facing changes?