[server] A few WCAA performance improvements #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I recall that one of the WC code paths has a comment explaining why LL is used here... can you search for it and make sure there is no unintended effect? If it still looks good, then let's update or delete that comment... |
1. Adopt fast-avro in the AAWC code path. 2. Use a schema-id based serde cache to avoid expensive schema comparison. 3. Dynamically choose the right structure for different logics, such as LinkedList vs ArrayList.
gaojieliu
force-pushed
the
aa_wc_optimization
branch
from
5b44db8
to
9c23748
Compare
gaojieliu
changed the title
gaojieliu
requested review from
sixpluszero and
FelixGV
and removed request for
sixpluszero
FelixGV
reviewed
Nov 1, 2023
...vinci-client/src/main/java/com/linkedin/davinci/replication/merge/MergeConflictResolver.java
Show resolved
Hide resolved
...vinci-client/src/main/java/com/linkedin/davinci/replication/merge/MergeConflictResolver.java
Show resolved
Hide resolved
...vinci-client/src/main/java/com/linkedin/davinci/replication/merge/MergeConflictResolver.java
Outdated
Show resolved
Hide resolved
...lient/src/main/java/com/linkedin/davinci/schema/merge/SortBasedCollectionFieldOpHandler.java
Outdated
Show resolved
Hide resolved
...client/src/main/java/com/linkedin/davinci/serializer/avro/MapOrderPreservingDatumReader.java
Show resolved
Hide resolved
elijahgrimaldi
pushed a commit
to elijahgrimaldi/venice
that referenced
this pull request
Nov 1, 2023
* [server] A few WCAA performance improvements 1. Adopt fast-avro in the AAWC code path. 2. Use a schema-id based serde cache to avoid expensive schema comparison. 3. Dynamically choose the right structure for different logics, such as LinkedList vs ArrayList. * Fixed spotbug issue * Fixed test coverage issue * Addressed comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LinkedList vs ArrayList.
How was this PR tested?
CI
Does this PR introduce any user-facing changes?