[vpj][controller][common] Add KME schema reader into repush #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clients/venice-push-job/src/main/java/com/linkedin/venice/hadoop/VenicePushJob.java
Outdated
Show resolved
Hide resolved
gaojieliu
reviewed
Sep 21, 2023
...ts/venice-push-job/src/main/java/com/linkedin/venice/hadoop/input/kafka/KafkaInputUtils.java
Outdated
Show resolved
Hide resolved
clients/venice-push-job/src/test/java/com/linkedin/venice/hadoop/VenicePushJobTest.java
Outdated
Show resolved
Hide resolved
shuhui-liu
force-pushed
the
repushKMESchemaReader
branch
from
a3febfe
to
4c5d205
Compare
shuhui-liu
changed the title
gaojieliu
approved these changes
Oct 31, 2023
clients/venice-push-job/src/main/java/com/linkedin/venice/hadoop/VenicePushJob.java
Show resolved
Hide resolved
...ts/venice-push-job/src/main/java/com/linkedin/venice/hadoop/input/kafka/KafkaInputUtils.java
Show resolved
Hide resolved
elijahgrimaldi
pushed a commit
to elijahgrimaldi/venice
that referenced
this pull request
Nov 1, 2023
…#623) Today KIF repush does not have KME schema reader. During KME upgrades, if controllers deploy first, they will produce control messages with new KME, then repush will fail because it could not find the new KME in code to deserialize these messages. The commit adds schema reader support into KIF repush so that repush can retrieve unknown KME from source colo system store. Note: do not set system.schema.reader.enabled to true in a repush job before the commit gets deployed to controllers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Today KIF repush does not have KME schema reader. During KME upgrades, if controllers deploy first, controller will produce control messages with new KME, and repush will fail because it could not find the new KME in code to deserialize these messages. The commit adds schema reader support into KIF repush so that repush can retrieve unknown KME from source colo system store.
How was this PR tested?
New integ test
Does this PR introduce any user-facing changes?