Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[server] ReadWriteLock on LeaderFollowerState #1251

Closed
wants to merge 7 commits into from
Closed

[server] ReadWriteLock on LeaderFollowerState #1251

wants to merge 7 commits into from

Commits on Oct 31, 2024

  1. The leader to follower transition test is working. 🍾

    @KaiSernLim
    KaiSernLim committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    569f66a View commit details
    Browse the repository at this point in the history

  2. Improved readability and reliability. 🪭🪭

    @KaiSernLim
    KaiSernLim committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    9b02b5f View commit details
    Browse the repository at this point in the history

  3. Added ReadWriteLock to LeaderFollowerStateType. 🔒

    @KaiSernLim
    KaiSernLim committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    9e68345 View commit details
    Browse the repository at this point in the history

  4. Added lots of comments explaining what's going on. ⛸️

    @KaiSernLim
    KaiSernLim committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    af7fd9a View commit details
    Browse the repository at this point in the history

  5. Did a bit more cleaning up. 🧹

    @KaiSernLim
    KaiSernLim committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    e20d24c View commit details
    Browse the repository at this point in the history

  6. Using AutoCloseableLock instead of manually using lock() and `unl… 

    …ock()`, which can be error-prone. 💹
    @KaiSernLim
    KaiSernLim committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a4b050c View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. Moved VeniceReentrantReadWriteLock from `venice.service.venice-cont… 

    …roller` into `internal/venice-client-common` and used it in `PartitionConsumptionState`. 🍿
    @KaiSernLim
    KaiSernLim committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    5394f52 View commit details
    Browse the repository at this point in the history