[client][test] Increase socket timeout for HTTP client5 (#544)

Co-authored-by: Sourav Maji <[email protected]>

clients/venice-client/src/main/java/com/linkedin/venice/fastclient/transport/HttpClient5BasedR2Client.java

@@ -13,6 +13,7 @@
 import java.util.Arrays;
 import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
 import javax.net.ssl.SSLContext;
 import org.apache.hc.client5.http.async.methods.SimpleHttpResponse;
 import org.apache.hc.client5.http.async.methods.SimpleRequestBuilder;
@@ -29,6 +30,8 @@
  * TODO: get rid of R2 Client inferface completely from venice-client.
  */
 public class HttpClient5BasedR2Client {
+  private static final long requestTimeOutInMilliseconds = TimeUnit.SECONDS.toMillis(1); // 1s by default
+
   public static final String HTTP_METHOD_GET_LOWER_CASE = "get";
   public static final String HTTP_METHOD_POST_LOWER_CASE = "post";
 
@@ -44,12 +47,17 @@ public static Client getR2Client(SSLContext sslContext) throws Exception {
   }
 
   public static Client getR2Client(SSLContext sslContext, int ioThreadCount) throws Exception {
+    return getR2Client(sslContext, ioThreadCount, requestTimeOutInMilliseconds);
+  }
+
+  public static Client getR2Client(SSLContext sslContext, int ioThreadCount, long responseTimeout) throws Exception {
     if (ioThreadCount <= 0) {
       throw new VeniceClientException("ioThreadCount should be greater than 0");
     }
 
     final CloseableHttpAsyncClient client = new HttpClient5Utils.HttpClient5Builder().setIoThreadCount(ioThreadCount)
         .setSslContext(sslContext)
+        .setRequestTimeOutInMilliseconds(responseTimeout)
         // Disable cipher check for now.
         .setSkipCipherCheck(true)
         .buildAndStart();

internal/venice-client-common/src/main/java/com/linkedin/venice/httpclient5/HttpClient5Utils.java

@@ -37,7 +37,7 @@ public static class HttpClient5Builder {
     private long requestTimeOutInMilliseconds = TimeUnit.SECONDS.toMillis(1); // 1s by default
     /**
      * We need to use a high connect timeout to avoid reconnect issue, which might result in confusing logging and unhealthy requests.
-     * For now, we remove the functions updating the connect timeout to avoid mistakes.
+     * For now, we remove the functions updating to connect timeout to avoid mistakes.
      */
     private final Timeout CONNECT_TIMEOUT_IN_MILLISECONDS = Timeout.ofMilliseconds(TimeUnit.MINUTES.toMillis(1)); // 1m
                                                                                                                   // by
@@ -54,7 +54,7 @@ public HttpClient5Builder setSslContext(SSLContext sslContext) {
       return this;
     }
 
-    public HttpClient5Builder setRequestTimeOutInMilliseconds(int requestTimeOutInMilliseconds) {
+    public HttpClient5Builder setRequestTimeOutInMilliseconds(long requestTimeOutInMilliseconds) {
       this.requestTimeOutInMilliseconds = requestTimeOutInMilliseconds;
       return this;
     }

internal/venice-test-common/src/main/java/com/linkedin/venice/fastclient/utils/ClientTestUtils.java

@@ -52,7 +52,7 @@ public static Client getR2Client(FastClientHTTPVariant fastClientHTTPVariant) th
         return setupTransportClientFactory(fastClientHTTPVariant);
 
       case HTTP_2_BASED_HTTPCLIENT5:
-        return HttpClient5BasedR2Client.getR2Client(SslUtils.getVeniceLocalSslFactory().getSSLContext(), 8);
+        return HttpClient5BasedR2Client.getR2Client(SslUtils.getVeniceLocalSslFactory().getSSLContext(), 8, 5000);
 
       default:
         throw new VeniceException("Unsupported Http type: " + fastClientHTTPVariant);