Fixed static analysis

linkedin · Feb 2, 2024 · 0085e0e · 0085e0e
1 parent db27699
commit 0085e0e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 16 deletions.
diff --git a/...da-vinci-client/src/main/java/com/linkedin/davinci/kafka/consumer/StoreIngestionTask.java b/...da-vinci-client/src/main/java/com/linkedin/davinci/kafka/consumer/StoreIngestionTask.java
@@ -809,11 +809,8 @@ protected boolean isReadyToServe(PartitionConsumptionState partitionConsumptionS
 
     try {
       // Looks like none of the short-circuitry fired, so we need to measure lag!
-      long offsetThreshold = getOffsetToOnlineLagThresholdPerPartition(
-          hybridStoreConfig,
-          storeRepository,
-          storeName,
-          subPartitionCount);
+      long offsetThreshold =
+          getOffsetToOnlineLagThresholdPerPartition(hybridStoreConfig, storeRepository, storeName, subPartitionCount);
       long producerTimeLagThresholdInSeconds =
           hybridStoreConfig.get().getProducerTimestampLagThresholdToGoOnlineInSeconds();
       String msg = msgForLagMeasurement[partitionId];
@@ -1160,7 +1157,7 @@ private void processIngestionException() {
          */
         if (partitionException instanceof MemoryLimitExhaustedException
             || partitionException.getCause() instanceof MemoryLimitExhaustedException
-            && isCurrentVersion.getAsBoolean()) {
+                && isCurrentVersion.getAsBoolean()) {
           LOGGER.warn(
               "Encountered MemoryLimitExhaustedException, and ingestion task will try to reopen the database and"
                   + " resume the consumption after killing ingestion tasks for non current versions");
@@ -1708,11 +1705,8 @@ private void checkConsumptionStateWhenStart(
       long offsetLagDeltaRelaxFactor = serverConfig.getOffsetLagDeltaRelaxFactorForFastOnlineTransitionInRestart();
       long previousOffsetLag = newPartitionConsumptionState.getOffsetRecord().getOffsetLag();
       if (hybridStoreConfig.isPresent() && newPartitionConsumptionState.isEndOfPushReceived()) {
-        long offsetLagThreshold = getOffsetToOnlineLagThresholdPerPartition(
-            hybridStoreConfig,
-            storeRepository,
-            storeName,
-            subPartitionCount);
+        long offsetLagThreshold =
+            getOffsetToOnlineLagThresholdPerPartition(hybridStoreConfig, storeRepository, storeName, subPartitionCount);
         // Only enable this feature with positive offset lag delta relax factor and offset lag threshold.
         if (offsetLagDeltaRelaxEnabled && offsetLagThreshold > 0) {
           long offsetLag = measureHybridOffsetLag(newPartitionConsumptionState, true);
@@ -2880,8 +2874,8 @@ protected void validateMessage(
 
       return (isDataRecovery && isHybridMode() && partitionConsumptionState.getTopicSwitch() == null)
           || (topicManager.isTopicCompactionEnabled(pubSubTopic)
-          && LatencyUtils.getElapsedTimeInMs(consumerRecord.getPubSubMessageTime()) >= topicManager
-          .getTopicMinLogCompactionLagMs(pubSubTopic));
+              && LatencyUtils.getElapsedTimeInMs(consumerRecord.getPubSubMessageTime()) >= topicManager
+                  .getTopicMinLogCompactionLagMs(pubSubTopic));
     });
 
     try {
@@ -3863,4 +3857,4 @@ public boolean isProducingVersionTopicHealthy() {
     }
     return true;
   }
-}
+}
diff --git a/...inci-client/src/test/java/com/linkedin/davinci/kafka/consumer/StoreIngestionTaskTest.java b/...inci-client/src/test/java/com/linkedin/davinci/kafka/consumer/StoreIngestionTaskTest.java
@@ -2550,9 +2550,12 @@ public void testPartitionExceptionIsolation(AAConfig aaConfig) throws Exception
         assertNull(
             storeIngestionTaskUnderTest.getPartitionIngestionExceptionList().get(PARTITION_FOO),
             "Exception for the errored partition should be cleared after unsubscription");
-        assertEquals(storeIngestionTaskUnderTest.getFailedPartitions().size(), 1, "Only one partition should be failed");
+        assertEquals(
+            storeIngestionTaskUnderTest.getFailedPartitions().size(),
+            1,
+            "Only one partition should be failed");
       });
-      }, aaConfig);
+    }, aaConfig);
     for (int i = 0; i < 10000; ++i) {
       storeIngestionTaskUnderTest
           .setIngestionException(0, new VeniceException("new fake looooooooooooooooong exception"));