Skip to content

Commit

Permalink
change LOG level to debug for commit offsets already in progress (#241)
Browse files Browse the repository at this point in the history
Offset commit already in progress is not a critical error that should kill the process.
Some commit tasks (Futures threads) take longer to complete and due to the nature of async commits, some commits take longer. Thus, changing level of Logging to debug is sufficient here.

Signed-off-by: Andrew Choi [email protected]
  • Loading branch information
Andrew Choi authored Apr 17, 2020
1 parent b418342 commit f681dc4
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -68,7 +68,7 @@ public void recordCommitStart() throws Exception {
_inProgressCommit = true;
} else {
// inProgressCommit is already set to TRUE;
throw new Exception("Offset commit is already in progress.");
LOG.debug("Offset commit is already in progress.");
}
}

@@ -83,7 +83,7 @@ public void recordCommitComplete() {
_inProgressCommit = false;
} else {
// inProgressCommit is already set to FALSE;
LOG.error("Offset commit is not in progress. CommitLatencyMetrics shouldn't completing a record commit here.");
LOG.debug("Offset commit is not in progress. CommitLatencyMetrics shouldn't completing a record commit here.");
}
}

0 comments on commit f681dc4

Please sign in to comment.